Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anything that uses remote_file under the hood should expose ssl_verify_mode #10356

Open
jaymzh opened this issue Aug 26, 2020 · 2 comments
Open
Labels
Aspect: Security Can an unwanted third party affect the stability or look at privileged information? Focus: Resources Triage: Feature Request Indicates an issue requesting new functionality.

Comments

@jaymzh
Copy link
Collaborator

jaymzh commented Aug 26, 2020

Describe the Enhancement:

We recently added ssl_verify_mode to remote_file. But there's no way to pass that through things like windows_package. We should expose that.

Describe the Need:

Same as the other need - being able to handle internal servers with self-signed certs.

@jaymzh jaymzh added the Status: Untriaged An issue that has yet to be triaged. label Aug 26, 2020
@tas50
Copy link
Contributor

tas50 commented Aug 26, 2020

Tagging this for the sustaining backlog.

@jaymzh
Copy link
Collaborator Author

jaymzh commented Sep 24, 2020

Turns out there is a way to do this already, at least for windows_package - there's a remote_file_attributes property which works great! That completely solves my problem, but looking through the code base I see a few that don't have this feature: cab_package, and zypper_repository.

packages/deb.rb uses remote_file, but there's no deb_package, and I don't see that dpkg_package allows URLs, so I'm not quite clear where the entry point for that one is.

@tas50 tas50 added Type: Enhancement Adds new functionality. Aspect: Security Can an unwanted third party affect the stability or look at privileged information? and removed Status: Untriaged An issue that has yet to be triaged. labels Apr 13, 2021
@tas50 tas50 added Triage: Feature Request Indicates an issue requesting new functionality. Focus: Resources and removed Type: Enhancement Adds new functionality. labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Security Can an unwanted third party affect the stability or look at privileged information? Focus: Resources Triage: Feature Request Indicates an issue requesting new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants