Cannot install snap_package with --classic option

[evandam]

Description

Attempting to install a snap package that requires --classic always fails. I also currently can only use :upgrade (not :install) from #10537.

Chef Version

Chef Infra Client, version 15.13.8

Confirmed this happens in 16.6.14 in Test Kitchen as well.

Platform Version

Ubuntu 18.04

Replication Case

snap_package 'amazon-ssm-agent' do
  options '--classic'
  action :upgrade
end

Client Output

* snap_package[amazon-ssm-agent] action upgrade[2020-11-02T16:48:24+00:00] INFO: Processing snap_package[amazon-ssm-agent] action upgrade (wo-common::ssm_agent line 10)


           ================================================================================
           Error executing action `upgrade` on resource 'snap_package[amazon-ssm-agent]'
           ================================================================================

           RuntimeError
           ------------
           status: Bad Request, kind: snap-needs-classic, message: snap "amazon-ssm-agent" requires classic confinement

           Resource Declaration:
           ---------------------
           # In /var/tmp/kitchen/cache/cookbooks/wo-common/recipes/ssm_agent.rb

            10: snap_package 'amazon-ssm-agent' do
            11:   options '--classic'
            12:   action :upgrade
            13: end
            14:

           Compiled Resource:
           ------------------
           # Declared in /var/tmp/kitchen/cache/cookbooks/wo-common/recipes/ssm_agent.rb:10:in `from_file'

           snap_package("amazon-ssm-agent") do
             package_name "amazon-ssm-agent"
             action [:upgrade]
             default_guard_interpreter :default
             declared_type :snap_package
             cookbook_name "wo-common"
             recipe_name "ssm_agent"
             options ["--classic"]
           end

           System Info:
           ------------
           chef_version=15.13.8
           platform=ubuntu
           platform_version=18.04
           ruby=ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-linux]
           program_name=/opt/chef/bin/chef-client
           executable=/opt/chef/bin/chef-client

[tas50]

This will be looked at in #10591

[terenho]

I checked the code in

chef/lib/chef/provider/package/snap.rb

Line 342 in 53941c5

request["classic"] = true if options.include?("classic")

, the way to specify '--classic' option should be

snap_package 'amazon-ssm-agent' do
  options 'classic'
  action :upgrade
end

At least that works for me