Hostname resource does not set fqdn on MacOS/Darwin

[feld]

Hostname, Domain name, and FQDNs should always be considered 3 separate values but I seem to run into this type of problem everywhere 😭🥴

chef/lib/chef/resource/hostname.rb

Lines 164 to 181 in 4ce99c4

	when darwin?
	# darwin
	execute "set HostName via scutil" do
	command "/usr/sbin/scutil --set HostName #{new_resource.hostname}"
	not_if { shell_out("/usr/sbin/scutil --get HostName").stdout.chomp == new_resource.hostname }
	notifies :reload, "ohai[reload hostname]"
	end
	execute "set ComputerName via scutil" do
	command "/usr/sbin/scutil --set ComputerName #{new_resource.hostname}"
	not_if { shell_out("/usr/sbin/scutil --get ComputerName").stdout.chomp == new_resource.hostname }
	notifies :reload, "ohai[reload hostname]"
	end
	shortname = new_resource.hostname[/[^\.]*/]
	execute "set LocalHostName via scutil" do
	command "/usr/sbin/scutil --set LocalHostName #{shortname}"
	not_if { shell_out("/usr/sbin/scutil --get LocalHostName").stdout.chomp == shortname }
	notifies :reload, "ohai[reload hostname]"
	end

The code for the resource always uses "hostname" for all values passed to scutil and ignores the existence of fqdn in the recipe. It is written to assume that the "hostname" value is the FQDN (which it is not, and should not be). You can see that by the "shortname" variable created by trying to split off the first label of the hostname which it thinks is the FQDN...

e.g.,

hostname macbook do
  fqdn macbook.example.com
end

Will always force the MacOS client to have a hostname of macbook and the FQDN is never applied. This does behave correctly on Linux hosts, for example.

[williamtheaker]

@feld would setting LocalHostName to the fqdn property fix this?