Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd time validation to the chef_client_systemd_timer resource #9644

Open
tas50 opened this issue Apr 9, 2020 · 0 comments
Open

Add systemd time validation to the chef_client_systemd_timer resource #9644

tas50 opened this issue Apr 9, 2020 · 0 comments

Comments

@tas50
Copy link
Contributor

tas50 commented Apr 9, 2020

We really want to make sure that folks input valid time values for these timers. If they put in bad data our systemd_unit validation will actually pass. It turns out that systemd-analyze verify which we run will throw error warnings to the shell, but doesn't fail if the time values are bad:

root@timnas2:/home/tsmith# systemd-analyze verify /etc/systemd/system/chef-client.timer
[/etc/systemd/system/chef-client.timer:8] Failed to parse timer value, ignoring: 1mi
root@timnas2:/home/tsmith# echo $?
0
@tas50 tas50 added Status: Untriaged An issue that has yet to be triaged. Type: Enhancement Adds new functionality. and removed Status: Untriaged An issue that has yet to be triaged. labels Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant