Add upgrade to chef_certgen NIF Without an upgrade function, we see the following error report when #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an upgrade function, we see the following error report when
running the unit tests:
=ERROR REPORT==== 11-Mar-2013::10:22:45 ===
The on_load function for module chef_certgen returned
{error,
{upgrade, "Upgrade not supported by this NIF library."}}
Adding upgrade that is identical to load resolves it.
|
Looks like something in the unit tests is triggering a double-load of the module. I don't see any harm in adding an empty upgrade callback to stop the error from happening. I spent some time looking at the unit tests and can't figure out what's causing chef_certgen to get loaded twice. |
|
rebased and merged. The error is only seen on OS X. But seems like a reasonable fix for now to make that go away. Tested that compile/test works on Linux still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running the unit tests:
Adding upgrade that is identical to load resolves it