Add upgrade to chef_certgen NIF Without an upgrade function, we see the following error report when #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

seth commented Mar 11, 2013

running the unit tests:

=ERROR REPORT==== 11-Mar-2013::10:22:45 ===
The on_load function for module chef_certgen returned
{error,
 {upgrade, "Upgrade not supported by this NIF library."}}

Adding upgrade that is identical to load resolves it

Add upgrade to chef_certgen NIF
Without an upgrade function, we see the following error report when
running the unit tests:

=ERROR REPORT==== 11-Mar-2013::10:22:45 ===
The on_load function for module chef_certgen returned
{error,
 {upgrade, "Upgrade not supported by this NIF library."}}

Adding upgrade that is identical to load resolves it.
Contributor

kevsmith commented Mar 11, 2013

Looks like something in the unit tests is triggering a double-load of the module. I don't see any harm in adding an empty upgrade callback to stop the error from happening. I spent some time looking at the unit tests and can't figure out what's causing chef_certgen to get loaded twice.

@seth seth closed this Mar 11, 2013

Owner

seth commented Mar 11, 2013

rebased and merged.

The error is only seen on OS X. But seems like a reasonable fix for now to make that go away. Tested that compile/test works on Linux still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment