Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Online tutorial: safari inspec online demo bug! #1086

Closed
arlimus opened this issue Sep 16, 2016 · 4 comments · Fixed by #1101 or #1191
Closed

www: Online tutorial: safari inspec online demo bug! #1086

arlimus opened this issue Sep 16, 2016 · 4 comments · Fixed by #1101 or #1191
Labels
Type: Bug Feature not working as expected
Milestone

Comments

@arlimus
Copy link
Contributor

arlimus commented Sep 16, 2016

No description provided.

@arlimus arlimus added the Type: Bug Feature not working as expected label Sep 16, 2016
@arlimus arlimus added this to the 0.35.0 milestone Sep 16, 2016
@chris-rock chris-rock modified the milestones: 0.35.0, 0.36.0, 1.0.0 Sep 19, 2016
@chris-rock chris-rock mentioned this issue Sep 21, 2016
5 tasks
@vjeffrey vjeffrey reopened this Sep 28, 2016
arlimus added a commit that referenced this issue Sep 28, 2016
javascript in Safari (and others) crashes on const declarations. See #1086
@arlimus arlimus modified the milestones: 1.1.0, 1.0.0 Sep 28, 2016
@vjeffrey
Copy link

'const declarations are not supported in strict mode'
apparently, safari doesn't understand things. silly safari.
babel should help with this.

@vjeffrey vjeffrey changed the title safari inspec online demo bug! www: Online tutorial: safari inspec online demo bug! Sep 28, 2016
@vjeffrey
Copy link

vjeffrey commented Sep 28, 2016

with babel loader and babel preset es2015, I set the webpack config to have:

            {
             test: /\.js$/,
             loader: 'babel',
             query: {
                presets: ['es2015']
             }
            }

in the module { loaders: [

Builds fine in chrome/firefox, but doesn't seem to be translating the const into var as expected with babel, so still same problem in safari.

I'll keep on digging into it/trying...

@vjeffrey
Copy link

this is the branch: dr/www/es-const haven't figured it out yet. still trying..

@vjeffrey
Copy link

https://github.com/chef/inspec/tree/vj/babelify-scripts <-- doing babel in gulpfile works to get rid of the const...but things are still not building correctly :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants