Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Online tutorial doesn't load (not building) #1182

Closed
2 tasks done
arlimus opened this issue Sep 28, 2016 · 2 comments
Closed
2 tasks done

www: Online tutorial doesn't load (not building) #1182

arlimus opened this issue Sep 28, 2016 · 2 comments
Labels
Type: Chore How can you have any pudding if you don't eat your meat?
Milestone

Comments

@arlimus
Copy link
Contributor

arlimus commented Sep 28, 2016

This occured for some builds on certain machines that don't have all the required modules installed (e.g. NodeJS).

Please make sure:

  • Fail the build process if any shell command fails (e.g. npm install)
  • Add sanity checks for build steps of: tutorial, docs, and www/middleman
@arlimus arlimus added the Type: Chore How can you have any pudding if you don't eat your meat? label Sep 28, 2016
@arlimus arlimus added this to the 1.1.0 milestone Sep 28, 2016
arlimus added a commit that referenced this issue Sep 28, 2016
@chris-rock
Copy link
Contributor

Do we want to use a docker based build? eg. via https://hub.docker.com/_/node/

@arlimus
Copy link
Contributor Author

arlimus commented Sep 29, 2016

@chris-rock That might be a great alternative. Instead of requiring node/npm we could just require docker, since it's a prerequisite for our tests anyway. I like the idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore How can you have any pudding if you don't eat your meat?
Projects
None yet
Development

No branches or pull requests

3 participants