Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspec supermarket profiles - update for new supermarket api #1255

Closed
alexpop opened this issue Oct 26, 2016 · 1 comment
Closed

inspec supermarket profiles - update for new supermarket api #1255

alexpop opened this issue Oct 26, 2016 · 1 comment
Labels
Type: Enhancement Improves an existing feature

Comments

@alexpop
Copy link
Contributor

alexpop commented Oct 26, 2016

In PR #1254 an intermediate fix for issue #1219 has been merged.

As the issue suggests, once chef/supermarket#1454 is implemented, we should update inspec to use the new supermarket search api call.

Adding the solution @robbkidd mentioned in #1219:


Possible Solutions

After a fix for chef/supermarket#1454 is released, the request parameters for the search in inspec supermarket can be updated. Pending the Supermarket release, the params will probably look like:

def self.profiles(supermarket_url = SUPERMARKET_URL)
      url = "#{supermarket_url}/api/v1/tools-search"
-       _success, data = get(url, { q: 'compliance_profile' })
+       _success, data = get(url, { type: 'compliance_profile' })
      if !data.nil?
@robbkidd
Copy link
Contributor

robbkidd commented Nov 8, 2016

Prospective fix for chef/supermarket#1454 opened for review in chef/supermarket#1463. Would love 👀 and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants