command resource check doesn't fail when it should

[walterdolce]

Description

Provided from the terminal I get:

$ which telnet
/usr/bin/telnet

Given the following control:

# encoding: utf-8
# copyright: 2015, Walter Dolce <walterdolce@gmail.com>
# license: Apache License 2.0
title 'telnet'

control 'telnet-executable-in-path' do
  impact 0.7
  title 'Verifies whether there is a telnet executable available in $PATH'
  desc title
  describe command('which telnet') do
    it { should_not exist }
  end
end

When I run InSpec it doesn't fail.
I would expect it to fail given the test says "make sure there's no executable named telnet callable from within the $PATH".

InSpec and Platform Version

InSpec version is 1.0.0
Platform info:

Name:      mac_os_x
Family:    darwin
Release:   10.10.5
Arch:      x86_64

Replication Case

You should be able to run the control above as is.

Possible Solutions

Not sure yet. Will have to have a look at InSpec's code.

Stacktrace

None available.

[walterdolce]

I am investigating this issue while someone comes in and replies.

This line of code is being executed and it's returning:
bash: line 0: type: which telnet: not found

But if I do:

fish-shell$ bash
bash-shell$ which telnet
/usr/bin/telnet

Or:

fish-shell$ bash -c "which telnet"
/usr/bin/telnet

Why are commands being run this way?

bash -c 'type "{{command}}"'

[walterdolce]

Hm. I guess I should change:

describe command('which telnet') do
    it { should_not exist }
end

To just:

describe command('telnet') do
    it { should_not exist }
  end

Or change the expectation:

describe command('which telnet') do
    its('exit_status') { should_not eq 0 }
end

[walterdolce]

I think I answered my own question. Will use:

describe command('telnet') do
   it { should_not exist }
end

Which I find more readable and does strip the dependency on which out.