Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML file extensions support only (.yml) #1569

Closed
mr-exz opened this issue Mar 17, 2017 · 6 comments
Closed

YAML file extensions support only (.yml) #1569

mr-exz opened this issue Mar 17, 2017 · 6 comments
Labels
Type: Bug Feature not working as expected

Comments

@mr-exz
Copy link
Contributor

mr-exz commented Mar 17, 2017

Description

Ignoring loading of attributes files

inspec exec ./test.rb --attrs ./test.yaml 
example.com should
     ∅  eq "example2.com"

     expected: "example2.com"
          got: "example.com"

     (compared using ==)

InSpec and Platform Version

os: CentOS 7
inspec: 1.16.1

Possible Solutions

here: https://github.com/chef/inspec/blob/725e0a1bc50008c8ad252bd8d5c833a7af20c606/lib/inspec/secrets/yaml.rb

You use filter for file name target.end_with?('.yml')

But in wiki for YAML file we have both extensions https://en.wikipedia.org/wiki/YAML

Filename extension	.yaml, .yml

It make me confused, maybe it good for you to remove this filter for file name, because people can use other name.

@chris-rock chris-rock added the Type: Bug Feature not working as expected label Mar 17, 2017
@chris-rock
Copy link
Contributor

Agreed @mr-exz Are you going to open a PR to fix that?

@mr-exz
Copy link
Contributor Author

mr-exz commented Mar 17, 2017

ok i'll try do it

mr-exz added a commit to mr-exz/inspec that referenced this issue Mar 18, 2017
@mr-exz
Copy link
Contributor Author

mr-exz commented Mar 18, 2017

create PR #1575

@adamleff
Copy link
Contributor

New PR for this is #1589.

@mr-exz
Copy link
Contributor Author

mr-exz commented Mar 22, 2017

Thx, i forgot to linked it

@adamleff
Copy link
Contributor

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

No branches or pull requests

3 participants