Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize internal implementation of 3 AWS resources #2633

Closed
clintoncwolfe opened this issue Feb 13, 2018 · 0 comments
Closed

Normalize internal implementation of 3 AWS resources #2633

clintoncwolfe opened this issue Feb 13, 2018 · 0 comments
Labels
Component: Core Resources Resources shipped with InSpec. Platform: AWS Amazon Web Services-related issues Type: Chore How can you have any pudding if you don't eat your meat?

Comments

@clintoncwolfe
Copy link
Contributor

Description

Three AWS resources, aws_iam_password_policy, aws_ec2_instance, and aws_iam_root_user were implemented early in the life of the project, using dependency injection for testing and 'resource' style AWS API calls. Those choices are valid in isolation, but all other AWS resources use a standardized approach using the AwsSingularResourceMixin or AwsPluralResourceMixin, which provides a variety of validation, testing, and (with #2613) exception handling facilities, allowing the resource code to be brief and distinct to the needs of the resource (and the AWS API that backs it).

Until the three resources are refactored, we must duplicate (or omit) any such shared functionality in the resources.

InSpec and Platform Version

InSpec 2.0 pre-release, branch release-2.0, 469369f

@clintoncwolfe clintoncwolfe added Type: Chore How can you have any pudding if you don't eat your meat? resource Platform: AWS Amazon Web Services-related issues labels Feb 13, 2018
@clintoncwolfe clintoncwolfe added Component: Core Resources Resources shipped with InSpec. and removed resource labels Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Resources Resources shipped with InSpec. Platform: AWS Amazon Web Services-related issues Type: Chore How can you have any pudding if you don't eat your meat?
Projects
None yet
Development

No branches or pull requests

2 participants