Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape commands before we execute them #70

Closed
chris-rock opened this issue Oct 5, 2015 · 1 comment
Closed

Escape commands before we execute them #70

chris-rock opened this issue Oct 5, 2015 · 1 comment
Milestone
0.8.0

Comments

@chris-rock
Copy link
Contributor

Use http://ruby-doc.org/stdlib-2.0.0/libdoc/shellwords/rdoc/Shellwords.html for command escape
@chris-rock chris-rock modified the milestones: 1.0.0, 0.8.0 Oct 5, 2015
@arlimus
Copy link
Contributor

arlimus commented Oct 20, 2015

Great point!

This should actually be done in train, where it is currently implemented for local (using shellout). The execution in the other backends uses their own method: docker (via docker.exec), ssh (via channel.exec), winrm (via powershell script). We may still need to escape it, especially considering sudo is entering the mix.

@arlimus arlimus closed this as completed Oct 20, 2015
clintoncwolfe pushed a commit that referenced this issue Jul 7, 2023
@dependabot
Bump omnibus from 15122f2 to 9c0643a in /omnibus (#70)
28031ae 
Bumps [omnibus](https://github.com/chef/omnibus) from `15122f2` to `9c0643a`.
- [Release notes](https://github.com/chef/omnibus/releases)
- [Commits](chef/omnibus@15122f2...9c0643a)

---
updated-dependencies:
- dependency-name: omnibus
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@chris-rock @arlimus