Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_config and sshd_config matchers should be case-insensitive #759

Closed
lamont-granquist opened this issue May 16, 2016 · 4 comments
Closed
Labels
Type: Bug Feature not working as expected
Milestone

Comments

@lamont-granquist
Copy link
Contributor

ssh itself does case insensitive parsing of its options, so these should both pass if the config file parser finds 'gssapiauthentication no', 'GssapiAuthentication no' or 'GSSAPIAuthentication no'

its('GssapiAuthentication') { should eq 'no' }
its('GSSAPIAuthentication') { should eq 'no' }
@chris-rock
Copy link
Contributor

We introduced the cmp matcher to cover this, just do not check with eq:

its('GssapiAuthentication') { should cmp 'no' }
its('GSSAPIAuthentication') { should cmp 'no' }

@lamont-granquist
Copy link
Contributor Author

i'm talking about the other side though... the "gssapiauthentication" side rather than the "no" side...

@chris-rock chris-rock added Type: Bug Feature not working as expected and removed question labels Jul 26, 2016
@chris-rock chris-rock added this to the 1.0.0 milestone Jul 26, 2016
@chris-rock chris-rock modified the milestones: 0.31.0, 1.0.0 Aug 15, 2016
@vjeffrey vjeffrey self-assigned this Aug 15, 2016
@arlimus
Copy link
Contributor

arlimus commented Aug 15, 2016

Full example:

describe ssh_config do
  its('GSSAPIAuthentication') { should cmp 'no' }
  its('GssapiAuthentication') { should cmp 'no' }
end

with /etc/ssh/ssh_config containing

GSSAPIAuthentication no

@chris-rock
Copy link
Contributor

fixed by #919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

No branches or pull requests

4 participants