Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is killing my eyes!!!!!!!!! #951

Closed
vjeffrey opened this issue Aug 22, 2016 · 11 comments
Closed

this is killing my eyes!!!!!!!!! #951

vjeffrey opened this issue Aug 22, 2016 · 11 comments
Assignees
Labels
Type: Enhancement Improves an existing feature
Milestone

Comments

@vjeffrey
Copy link

Description

hurts my eyes

staring at the various font/color stuff that's happening here is killin me.

InSpec and Platform Version

0.30.0

Replication Case

exec a profile that has a mixture of controls and standalone describe blocks with a variety of expected failures

@arlimus
Copy link
Contributor

arlimus commented Aug 22, 2016

Confirmed, these colors are driving me insane as well; Let's find a better design in this ticket...

@arlimus arlimus added the Type: Enhancement Improves an existing feature label Aug 22, 2016
@ksubrama
Copy link

ksubrama commented Aug 22, 2016

:) @vjeffrey wanted some powershell examples. Here's a beautiful one...
screen shot 2016-08-22 at 14 27 13

But then again... this is why we all install conemu or cmder on windows.

@arlimus
Copy link
Contributor

arlimus commented Aug 22, 2016

@ksubrama Thank you for sharing!! interesting to see that the critical failure is much more readable than the the normal ones (i.e. regular red output).

@chris-rock chris-rock modified the milestone: 1.0.0 Aug 26, 2016
@chris-rock chris-rock modified the milestones: 1.0.0, 1.1.0 Sep 21, 2016
@jkerry
Copy link
Contributor

jkerry commented Nov 20, 2016

Anyone have a color palate suggestion that is preferred? Pretty sure this can be toggled pretty easily in the cli rspec formatter class

@arlimus
Copy link
Contributor

arlimus commented Nov 21, 2016

One more confirmation for this one from this morning: We demoed it via test-kitchen and were running on dark background. Any failed results were so hard to read, that we must really switch this. We'll get our UX expert on it. Let's get this closed quickly.

We have overridden the formatter for reporting, but it should stay very easy 😁

@arlimus arlimus self-assigned this Nov 21, 2016
@arlimus
Copy link
Contributor

arlimus commented Nov 21, 2016

@jkerry yeah, spot on: https://relishapp.com/rspec/rspec-core/v/2-14/docs/formatters/configurable-colors
I'd love to disconnect it slightly from RSpec core, but have it pull these colors in if they are available.

@arlimus arlimus added the ready label Nov 21, 2016
@arlimus
Copy link
Contributor

arlimus commented Nov 21, 2016

pulling this ticket into waffle 😉 https://waffle.io/chef/inspec

@arlimus
Copy link
Contributor

arlimus commented Nov 21, 2016

cc @hannah-radish

@hannah-radish
Copy link
Contributor

screen shot 2016-11-22 at 4 14 07 pm

screen shot 2016-11-22 at 4 14 16 pm

Updated the style guide here as well: https://github.com/chef/inspec/pull/1313/files

@vjeffrey
Copy link
Author

fixed by: 91fe22f

@chris-rock
Copy link
Contributor

Thank you @vjeffrey @hannah-radish for the great improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants