always display error message #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/cli-report-show-errors
branch
from
d11e77e
to
190c472
Compare
chris-rock
force-pushed
the
chris-rock/cli-report-show-errors
branch
from
190c472
to
7806bf6
Compare
chris-rock
force-pushed
the
chris-rock/cli-report-show-errors
branch
from
7806bf6
to
42ebaa1
Compare
chris-rock
changed the title
chris-rock
force-pushed
the
chris-rock/cli-report-show-errors
branch
from
42ebaa1
to
cb71f15
Compare
chris-rock
force-pushed
the
chris-rock/cli-report-show-errors
branch
from
cb71f15
to
0a34ffe
Compare
chris-rock
changed the title
|
👍 This looks correct, but to be honest this class has quiet a few conditionals and special cases. I think that the next time we need to look at a bug fix in the reporter we should think about whether there is a refactoring that would slow the rate of conditionals we seem to need to add to the reporter. |
|
@stevendanna Yeah, I am close to refactor the cli reporter :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1016