Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use winrm v2 #1018

Merged
merged 3 commits into from
Sep 5, 2016
Merged

use winrm v2 #1018

merged 3 commits into from
Sep 5, 2016

Conversation

chris-rock
Copy link
Contributor

@@ -18,5 +18,5 @@

# ensure that we do not require a newline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment implies that the property we were trying to test was explicitly that the user doesn't need to supply the line ending; but the change to the test implies they now do have to provide the line ending.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, let me double-check that

@stevendanna
Copy link
Contributor

👍 An alternative to mutating the text that we get back would be to move the "indifferent to linespace ending" behavior into the matcher.

@chris-rock
Copy link
Contributor Author

@stevendanna i tried that first, but other powershell methods like strip rely on response.stdout. Therefore I decided for that specific approach. Also VBScript somethings treats 2 newlines as one. With this approach we are always sure.

@chris-rock chris-rock merged commit 782e4da into master Sep 5, 2016
@chris-rock chris-rock deleted the chris-rock/winrm-v2 branch September 5, 2016 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants