Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow direct access to iis configuration parameters #1020

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

chris-rock
Copy link
Contributor

The current IIS resource has not exposed the data without a matcher:

# test the site with the resource
describe iis_site('Default Web Site') do
  it { should exist }
  it { should be_running }
  it { should have_app_pool('DefaultAppPool') }
  it { should have_binding('http *:80:') }
  it { should have_path('%SystemDrive%\\inetpub\\wwwroot') }
end

This PR allows users to access the data directly

# test the site with the resource
describe iis_site('Default Web Site') do
  it { should exist }
  it { should be_running }
  its('app_pool') { should eq 'DefaultAppPool' }
  its('bindings') { should include 'http *:80:' }
  its('path') { should eq '%SystemDrive%\\inetpub\\wwwroot' }
end

@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Sep 5, 2016
@chris-rock
Copy link
Contributor Author

cc @chrisevett

@stevendanna
Copy link
Contributor

👍 This looks like a reasonable improvement. Give how much this class delegates to the SiteProvider, it makes me wonder if they should be one class, but I don't know where else this is used.

@chris-rock chris-rock merged commit 80fd288 into master Sep 7, 2016
@chris-rock chris-rock deleted the chris-rock/iis_direct_matcher branch September 7, 2016 09:34
@chris-rock chris-rock modified the milestone: 0.34.0 Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants