Remove SourceReader::Inspec#prepare_load_path #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already monkeypatch require so that it is redirected through the require_loader. All of the tests pass with this removal. We might cause some breakage with this removal that we aren't testing, but given that we are mucking with `require` it seems preferable to have one mechanism by which we do that and solve any bugs with that single path. Signed-off-by: Steven Danna <steve@chef.io>
chris-rock
force-pushed
the
ssd/remove-prepare_load_path
branch
from
99da648
to
210dbc9
Compare
|
I agree, that we should have only one implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already monkeypatch require so that it is redirected through the
require_loader. All of the tests pass with this removal. We might
cause some breakage with this removal that we aren't testing, but given
that we are mucking with
requireit seems preferable to have onemechanism by which we do that and solve any bugs with that single path.
Signed-off-by: Steven Danna steve@chef.io