ssl resource fix and speed improvement #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
added
Type: Bug
| @@ -44,6 +46,11 @@ class SSL < Inspec.resource(1) | |||
| def initialize(opts = {}) | |||
| @host = opts[:host] || | |||
| inspec.backend.instance_variable_get(:@hostname) | |||
| # FIXME: This can be removed when/if @hostname is available as a property for 'Train::Transports::WinRM::Connection' | |||
| # Train enhancement request for this here: https://github.com/chef/train/issues/128 | |||
| if @host.nil? && inspec.backend.class.to_s == 'Train::Transports::WinRM::Connection' | |||
There was a problem hiding this comment.
It feels like we do not want to add this here, but instead we want to improve train directly. Could you push a PR for train, so that we can depend on that?
There was a problem hiding this comment.
Please get this merged first. We can remove it in the second cycle and improve train. I don't think we should block this change because of a minor adjustment.
parallelize protocol checks to speed up the scan
chris-rock
force-pushed
the
ap/ssl-improvements
branch
from
10dbf58
to
f65ceeb
Compare
|
The FIXME is followed up in inspec/train#128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot determine host for SSL test. Please specify it or use a different target.