Improve duplicate and cycle detection in resolver #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
changed the title
stevendanna
force-pushed
the
ssd/dup-detect
branch
from
2b01a79
to
f984a57
Compare
stevendanna
changed the title
stevendanna
force-pushed
the
ssd/dup-detect
branch
from
f984a57
to
50ac852
Compare
| else | ||
| "the dependency information for #{path_string.split(' ').last}" | ||
| end | ||
| fail Inspec::DuplicateDep, "The dependency #{dep.name} is listed twice in #{problem_cookbook}" |
There was a problem hiding this comment.
I think it may makes sense to add a test for that behavior?
There was a problem hiding this comment.
There is a test that ensures we detect duplicates:
https://github.com/chef/inspec/pull/1038/files#diff-a1477bbe856a2707fce873a5096df630R28
Do you think we should test the content of the error message as well?
There was a problem hiding this comment.
Uh missed that. Thanks @stevendanna
Signed-off-by: Steven Danna <steve@chef.io>
stevendanna
force-pushed
the
ssd/dup-detect
branch
from
50ac852
to
b48b9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steven Danna steve@chef.io