use simple config for security policy resource #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/security_policy
branch
from
36c60e1
to
1ace17e
Compare
chris-rock
force-pushed
the
chris-rock/security_policy
branch
from
b76cbfa
to
f87a922
Compare
| read_content | ||
| end | ||
|
|
||
| def params(*opts) |
There was a problem hiding this comment.
A number of the resources include a params function that feels similar. Might be nice to pull this out into a module where the behavior can be tested once.
It's a bit strange that some of the resources take arguments for their params method while others return a hash.
Fine for now, just figured it was worth pointing out.
There was a problem hiding this comment.
Agree, resources need some harmonization here and it would be nice to extract some basics. This improvement makes sense to me...
|
This appears to be following the conventions of the other resources we have. 👍 |
chris-rock
force-pushed
the
chris-rock/security_policy
branch
from
d7cfc8f
to
2829c4c
Compare
chris-rock
force-pushed
the
chris-rock/security_policy
branch
from
2829c4c
to
9c7d06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
security_policyresourcessh_configsecurity_policy.contentto retrieve the plain file contentsecurity_policy.paramsto retrieve the parsed parameters