Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force encoding in bin only #1062

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Force encoding in bin only #1062

merged 1 commit into from
Sep 13, 2016

Conversation

chris-rock
Copy link
Contributor

move force encoding to binary only, so that it does not affect the use of inspec in lib mode.

As reported, InSpec in audit cookbook changed the default encoding for ruby. Therefore the following error occurred:

 * remote_file[/var/chef/cache/webfiles.tar.gz] action create

    ================================================================================
    Error executing action `create` on resource 'remote_file[/var/chef/cache/webfiles.tar.gz]'
    ================================================================================

    Encoding::UndefinedConversionError
    ----------------------------------
    "\x8B" from ASCII-8BIT to UTF-8

Moving it to bin, keeps it standard for InSpec when used from shell, but does not enforce it for library modes

@chris-rock chris-rock added the Type: Bug Feature not working as expected label Sep 12, 2016
@jeremymv2
Copy link
Contributor

From an audit cookbook perspective, when I test this change it doesn't appear to have any negative consequences.

👍

@chris-rock chris-rock merged commit 31e945f into master Sep 13, 2016
@chris-rock chris-rock deleted the chris-rock/fix-encoding branch September 13, 2016 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants