Ensure resources are visible inside its blocks #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent changes to provide isolated views of the available resources was not extended to Rspec::ExampleGroups. This ensures that ExampleGroups have access to the same resources as the enclosing Inspec::Rule. Signed-off-by: Steven Danna <steve@chef.io>
stevendanna
force-pushed
the
ssd/issue-1074
branch
from
86de4c9
to
8024eea
Compare
stevendanna
changed the title
| end | ||
| end.compact | ||
|
|
||
| examples.each { |e| @test_collector.add_test(e, rule) } |
There was a problem hiding this comment.
So cool to get this removed
|
💯 Awesome work @stevendanna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to provide isolated views of the available resources
was not extended to Rspec::ExampleGroups. This ensures that
ExampleGroups have access to the same resources as the enclosing
Inspec::Rule.
Signed-off-by: Steven Danna steve@chef.io