print profile summary and test summary #1083
Conversation
|
this is what the two failing shell tests are running; it gives me the correct output here but comes back with an incorrect summary count in the functional tests :/ |
vjeffrey
force-pushed
the
vj/update-json-summary
branch
from
afb61a1
to
318a1fc
Compare
|
@vjeffrey I think the remaining failures are related to |
|
argh!!!!!! ok, i'll go try to fix that. argggg |
vjeffrey
force-pushed
the
vj/update-json-summary
branch
from
318a1fc
to
78bbf73
Compare
|
mo-flippin-o i'm down to one failing test. almost there. |
|
|
vjeffrey
force-pushed
the
vj/update-json-summary
branch
from
8c00855
to
8bfb1a1
Compare
vjeffrey
force-pushed
the
vj/update-json-summary
branch
from
8bfb1a1
to
e28572e
Compare
vjeffrey
changed the title
|
ready for review! |
| failed += 1 | ||
| elsif control[:results].any? { |r| r[:status] == 'skipped' } | ||
| skipped += 1 | ||
| @anonymous_tests.each do |control| |
There was a problem hiding this comment.
Please count control_tests too :)
| else | ||
| passed += 1 | ||
| passed +=1 |
| COLORS['passed'], 0, COLORS['reset'], | ||
| COLORS['failed'], 0, COLORS['reset'], | ||
| COLORS['skipped'], 0, COLORS['reset']) | ||
| output.puts(s) if @current_control.nil? || (@anonymous_tests.empty? && controls_res['total'] == 0) |
There was a problem hiding this comment.
Please remove this old-school summary and use the Test summary instead (adjusting functional tests)
vjeffrey
force-pushed
the
vj/update-json-summary
branch
from
e28572e
to
ecac8ae
Compare
|
comments addressed @arlimus :) |
|
|
|
Awesome improvement, thank you @vjeffrey !! 😄 |
i put a wip on it only because I'm working on getting the two shell functional tests that are failing to a passing state; i'm a little confused about why they're failing, since running the same thing those tests are running manually gives me the correct output.
fixes #852