Improve error messages from compliance fetcher #1126
Conversation
|
I am not convinced that a fetcher should exit the application. It may throw an exception, but it should never exit the application. If used as a library (as in audit cookbook), the fetcher is not executed as cli application. From my perspective only the CLI application should decide if an exit code should be thrown or not |
| module UI | ||
| def self.exit_with_error(message) | ||
| $stderr.puts message | ||
| exit(1) |
There was a problem hiding this comment.
I strongly advice against to exit application from an internal method.
| @@ -24,11 +25,23 @@ def self.resolve(target) | |||
|
|
|||
| # check if we have a compliance token | |||
| config = Compliance::Configuration.new | |||
| return nil if config['token'].nil? | |||
| if config['token'].nil? | |||
| Inspec::UI.exit_with_error <<EOF | |||
There was a problem hiding this comment.
Its a great idea to add better information about an error, but that should be encapsulated in exceptions
|
@chris-rock Yeah, I am not thrilled with exiting from here either. One of the issues with the exception is not dumping the stack trace which obscures the error message. |
stevendanna
force-pushed
the
ssd/better-compliance-errors
branch
from
5fd2df9
to
8d1b4d5
Compare
|
Updated per code review |
Signed-off-by: Steven Danna <steve@chef.io>
chris-rock
force-pushed
the
ssd/better-compliance-errors
branch
from
8d1b4d5
to
76ef897
Compare
Signed-off-by: Steven Danna steve@chef.io