Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace wmi win32_useraccount with adsi users #1149

Merged
merged 1 commit into from
Sep 25, 2016

Conversation

chris-rock
Copy link
Contributor

This improves the access time of users on windows drastically:

WMI Win32_User:

inspec> puts Benchmark.measure { users.where { username =~ /.*/}.uids.entries }
  0.110000   0.040000   0.150000 ( 28.337506)
=> nil
inspec> users.where { username =~ /.*/}.uids.entries 
=> ["S-1-5-21-1759981009-4135989804-1844563890-500", "S-1-5-21-1759981009-4135989804-1844563890-501", "S-1-5-21-1759981009-4135989804-1844563890-1001"]

ADSI:

inspec> puts Benchmark.measure { users.where { username =~ /.*/}.uids.entries }
  0.030000   0.010000   0.040000 (  0.166462)
=> nil
inspec> users.where { username =~ /.*/}.uids.entries 
=> ["S-1-5-21-1759981009-4135989804-1844563890-500", "S-1-5-21-1759981009-4135989804-1844563890-501", "S-1-5-21-1759981009-4135989804-1844563890-1001"]

@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Sep 25, 2016
@chris-rock chris-rock added this to the 1.0.0 milestone Sep 25, 2016
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement on the Windows side of things, thank you so much @chris-rock !!

@chris-rock chris-rock merged commit cd5905c into master Sep 25, 2016
@chris-rock chris-rock deleted the chris-rock/win-user-improve branch September 25, 2016 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants