Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial response filename length #1159

Merged
merged 2 commits into from
Oct 6, 2016

Conversation

chris-rock
Copy link
Contributor

Followup on #1143 to prevent long filenames for Windows environments

@arlimus
Copy link
Contributor

arlimus commented Oct 1, 2016

After some investigation, I found the underlying issue: Some of our systems generate CRLFs in these git commits, while @vjeffrey 's last update cleared it to LF line endings. IMHO this is the way we should choose instead of CRLF.

Github doesn't provide insight to this in their diff view.
Git on CLI can help, if you don't ignore CRLF diffs. They will show up as ^M characters at all line endings.

See http://stackoverflow.com/questions/1822849/what-are-these-ms-that-keep-showing-up-in-my-files-in-emacs


At this point I think we should avoid having all of these responses checked into the repo. More investigation...

@arlimus arlimus force-pushed the chris-rock/tutorial-response-filename-length branch from bbcfc33 to 7fd1d5e Compare October 2, 2016 21:43
@arlimus
Copy link
Contributor

arlimus commented Oct 2, 2016

Limited to the change without response updates for now. Kudos @chris-rock for atomic commits!!

@vjeffrey
Copy link

vjeffrey commented Oct 4, 2016

I pushed a commit to regenerate the responses...

@arlimus arlimus force-pushed the chris-rock/tutorial-response-filename-length branch 2 times, most recently from 9cd0a30 to fff91b9 Compare October 5, 2016 13:20
@vjeffrey vjeffrey force-pushed the chris-rock/tutorial-response-filename-length branch from 5ebdf00 to 3def69e Compare October 5, 2016 13:50
@arlimus arlimus force-pushed the chris-rock/tutorial-response-filename-length branch from 3def69e to 8789c0a Compare October 5, 2016 14:02
@arlimus arlimus force-pushed the chris-rock/tutorial-response-filename-length branch from 8789c0a to 4f1d085 Compare October 6, 2016 11:33
@arlimus
Copy link
Contributor

arlimus commented Oct 6, 2016

Thank you @chris-rock for fixing this!!
Kudos @vjeffrey for the updated responses.

@arlimus arlimus merged commit 4ee32eb into master Oct 6, 2016
@arlimus arlimus deleted the chris-rock/tutorial-response-filename-length branch October 6, 2016 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants