Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print profile info before test results (inherited profiles) #1170

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

vjeffrey
Copy link

fixes #1071

@vjeffrey
Copy link
Author

vjeffrey commented Sep 26, 2016

now:
screen shot 2016-09-26 at 1 09 51 pm

before:
screen shot 2016-09-26 at 1 11 28 pm

Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think that the observed behavior with this patch is an improvement. @vjeffrey and I discussed it a bit and there is still some unintended behavior when multiple profiles are passed on the command line, but we think that fixing that puts us past the tipping point where we actually need to just fix how controls and profiles are re-associated in the reporter.

That is a long way to say, let's merge this and do that work in another commit.

@vjeffrey vjeffrey merged commit 47c6427 into master Sep 27, 2016
@vjeffrey vjeffrey deleted the vj/fix-profile-output-inheritance branch September 27, 2016 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing reporter output with inherited profiles
3 participants