include control section in instructions #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/fix-instructions
branch
from
8052382
to
fd2889f
Compare
|
um, also, i had merged a change for the site earlier, and some changes to the main website hadn't been updated yet, so i just did the whole build to gh pages thing. confirmed all was working and good.....kinda maybe did it from this branch to get this fix in too i'm sorry i know that was prob not best form but i felt silly waiting sorrrryyyyyyy :) :) :) |
chris-rock
reviewed
Sep 28, 2016
| @@ -73,7 +73,7 @@ export class AppComponent implements OnInit { | |||
| let totalSteps = this.instructionsArray.length - 1; | |||
There was a problem hiding this comment.
may it makes sense to just change it to let totalSteps = this.instructionsArray.length?
There was a problem hiding this comment.
yup! just pushed up a change to that. :) nice catch!
vjeffrey
force-pushed
the
vj/fix-instructions
branch
from
fd2889f
to
e4acbcb
Compare
arlimus
force-pushed
the
vj/fix-instructions
branch
from
e4acbcb
to
0857b0a
Compare
arlimus
force-pushed
the
vj/fix-instructions
branch
from
0857b0a
to
2b71234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed we managed to leave out the controls part...