Website: Fix buggy behavior in nav and add global message #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a global message that will appear above the nav that can be customized to advertise upcoming events.
cwebberOps
approved these changes
Sep 30, 2016
|
@vjeffrey or @chris-rock can you take a quick look over this and approve if you are good with the changes? @magwalk Let's give the inspec team a chance to take a glance at this before we merge it. |
|
yup! i'll take a look in a few minutes. |
|
👍 looks great! thanks @magwalk @cwebberOps while I have your attention, could one of you do me a favor and take a look at/test #1191. the tutorial part of the site doesn't currently work with safari, that pr should fix it. ^^ nevermind about testing my pr. looks like there's still errors. grrrrr safari. |
|
Thanks @vjeffrey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where the nav overlaps with the footer on short screen sizes and adds a global message bar that can be modified/updated as needed.