Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show actual value for cmp octal comparisons in string to match expected #1211

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Show actual value for cmp octal comparisons in string to match expected #1211

merged 1 commit into from
Oct 13, 2016

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Oct 11, 2016 •
edited by arlimus
Loading

Before the change in this PR:

     ✖  File /tmp/sixhundred.txt mode should cmp == "0700"

     expected: "0700"
          got: 0600

After the change:

     ✖  File /tmp/sixhundred.txt mode should cmp == "0700"

     expected: "0700"
          got: "0600"

@alexpop alexpop added the Type: Enhancement Improves an existing feature label Oct 11, 2016
@arlimus
Copy link
Contributor

arlimus commented Oct 11, 2016

I like your approach @alexpop , let's do it
Once the tests are in we should get this merged

@arlimus arlimus added this to the 1.3.0 milestone Oct 11, 2016
@alexpop
Copy link
Contributor Author

alexpop commented Oct 11, 2016

Dom, I added a functional test for failure. Cheers!

@arlimus
Copy link
Contributor

arlimus commented Oct 13, 2016

Kudos @alexpop 😄

@arlimus arlimus merged commit ac24bba into master Oct 13, 2016
@arlimus arlimus deleted the ap/cmp-inspect branch October 13, 2016 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexpop alexpop

Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexpop @arlimus @adamhjk