adding by_user permissions support for windows

[jeremymv2]

This is a first stab at adding mvp support for checking read/write/execute file permissions, for a specific user.

  # verifies if a specific user has access to a file
    describe file("C:/users/vagrant/setup.bat") do
      it { should exist }
      it { should_not be_readable.by_user('vagrant-2012-r2\jdoe') }
      it { should be_readable.by_user('vagrant-2012-r2\vagrant') }
      it { should_not be_executable.by_user('vagrant-2012-r2\jdoe') }
      it { should be_executable.by_user('vagrant-2012-r2\vagrant') }
      it { should_not be_writable.by_user('vagrant-2012-r2\jdoe') }
      it { should be_writable.by_user('vagrant-2012-r2\vagrant') }
      it { should be_readable }
      it { should be_writeable }
      it { should be_executable }
    end

The above results in the following when vagrant-2012-r2\jdoe was denied access to the file:

I believe it addresses #783

It will fail unit tests since they will have to be refactored. If this passes muster I'll refactor the tests.

Signed-off-by: Jeremy J. Miller jm@chef.io

[jeremymv2]

@chris-rock @arlimus thoughts?

[chris-rock]

I think we should not skip the resource if the no perm_provider is available. Most of the file implementation is done in train anyway. I would prefer to move this skip return to the individual functions that cannot be executed aka readable? etc

[chris-rock]

This is the place where we should return the skip the resource

[chris-rock]

we should fail here, once we have the skip as the first statement of eg. in readable? this method should never be called if perms_provider is not defined.

[chris-rock]

we should return an error if the access_type is unknown

[chris-rock]

Awesome work @jeremymv2 I had some minor comments. Nothing difficult to improve. On top, I would prefer if we could add some integration tests as well in https://github.com/chef/inspec/blob/master/test/integration/default/file_spec.rb#L173-L200

[chris-rock]

👍

[chris-rock]

Awesome work @jeremymv2, lets rebase, fix the tests and I'll merge it. Let me know if I can help with fixing the tests.

[jeremymv2]

@chris-rock unit and integration tests added to the PR.
I heavily refactored the unit tests - let me know what you think.

[chris-rock]

Awesome @jeremymv2