Headers and list elements that include more than one _ character we…
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re being rendered incorrectly. (Perhaps it is only when there are an even number but in any case I only found words with either one or two `_`s.) The html rendered from markdown would look like: `<h3>be<em>grouped</em>into</h3>` When there is only one `_` the html rendered correctly: `<h3>be_directory</h3>` This change escapes the `_` when there are multiple. * New markdown: `### be\_grouped\_into` * New html: `<h3>be_grouped_into</h3>` resource matchers fixed: * be_block_device * be_character_device * be_grouped_into * be_linked_to * be_owned_by * have_app_pool * have_property_value resource fixed: * parse_config_file Signed-off-by: Nathen Harvey <nharvey@chef.io>
|
Thanks @nathenharvey for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers and list elements that include more than one
_character were being rendered incorrectly. (Perhaps it is only when there are an even number but in any case I only found words with either one or two_s.)The html rendered from markdown would look like:
<h3>be<em>grouped</em>into</h3>When there is only one
_the html rendered correctly:<h3>be_directory</h3>This change escapes the
_when there are multiple.### be\_grouped\_into<h3>be_grouped_into</h3>resource matchers fixed:
resource fixed:
Signed-off-by: Nathen Harvey nharvey@chef.io