Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with registry_key example #1243

Merged
merged 3 commits into from
Oct 25, 2016
Merged

Fix issue with registry_key example #1243

merged 3 commits into from
Oct 25, 2016

Conversation

seththoenen
Copy link
Contributor

There are two issues with this registry_key resource example.

  1. The hive in the example isn't wrapped in single-quotes. Ruby attempts to evaluate this as an object when it needs to be string data. Surrounding HKEY_USERS with single-quotes resolves this issue.

  2. The .each method expects the beginning of the provided array to be on the same line. Moving { |key| to directly follow .each allows the method to properly execute.

@chris-rock
Copy link
Contributor

@seththoenen Awesome thanks a lot! Just run git commit --amend -s to sign-off your work. We recently switched from signed CLAs to simple git commit signoffs. See https://github.com/chef/inspec/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Also great work on the InSpec tutorial http://seththoenen.com/inspec/ Would you like to add this to https://github.com/chef/inspec/blob/master/www/source/tutorials.html.slim?

Seth Thoenen added 2 commits October 25, 2016 10:41
Signed-off-by: Seth Thoenen <seththoenen@gmail.com>
@seththoenen
Copy link
Contributor Author

@chris-rock, I've signed-off on this commit. Please let me know if you need anything else from me.

I would be most honored if you would like to add the InSpec tutorials to the official tutorials page. Right now they are designed for people who don't have any experience with InSpec and are using Windows. I'm planning to expand these to more advanced InSpec topics in the future.

Thanks!

Seth

@chris-rock
Copy link
Contributor

Thanks @seththoenen for the fix for the example! Please add another PR for the tutorial.

@chris-rock chris-rock merged commit 23456c5 into inspec:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants