Use include instead of match in the error message #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as include behaves like contain and not match Signed-off-by: Artem Sidorenko <artem@posteo.de>
artem-sidorenko
force-pushed
the
include-matcher
branch
from
5342d85
to
e460ad1
Compare
|
@artem-sidorenko I think it makes sense to map it to |
|
@chris-rock Ok. I will have a look to rspec and how to do that, I'm not familiar with rspec on this level yet. Maybe it makes sense to merge this and I will provide another PR with mapping to |
|
@artem-sidorenko Yes it does make sense. Thanks @artem-sidorenko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as include behaves like contain (exact matching instead of regexp)
Related comment
Are they any reasons why contain is not mapped to include with a warning?
It might simplify the migration from serverspec, where deprecated contain matcher is used quite often