Fix attributes in profile dependencies #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/fix-attributes-in-dependencies
branch
2 times, most recently
from
87d7b6e
to
8789509
Compare
chris-rock
changed the title
chris-rock
force-pushed
the
chris-rock/fix-attributes-in-dependencies
branch
from
8789509
to
b4194e8
Compare
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/fix-attributes-in-dependencies
branch
from
b4194e8
to
4b22400
Compare
|
👍 |
|
Thanks for testing @vjeffrey |
|
nice work @chris-rock - this solved it for me! Thanks! ; ) |
|
@gsaslis Thanks, let us know if you find anything else that is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #1250