Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes resources in the docs #1303

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Fixes resources in the docs #1303

merged 1 commit into from
Nov 20, 2016

Conversation

burtlo
Copy link

@burtlo burtlo commented Nov 20, 2016

  • Fixes the npm package example to state 'npm' vs 'gem'
  • Fixes powershell resource to specify the resource instead of 'script'
  • Updates the vbscript example to rename script variable to 'script'

While ruby would allow the local variable and the presence of the InSpec method at the same time I think that it is bad form. Other resource examples also use 'script'.

  • Changes pip to show generic example

Other package like resources show a generic example in the default.

* Fixes the npm package example to state 'npm' vs 'gem'
* Fixes powershell resource to specify the resource instead of 'script'
* Updates the example to rename variable 'script'

While ruby would allow the local variable and the presence of the InSpec method at the same time I think that it is bad form. Other resource examples also use 'script'.

* Changes pip to show generic example

Other package like resources show a generic example in the default.

Signed-off-by: Franklin Webber <franklin@chef.io>
@chris-rock
Copy link
Contributor

@burtlo Awesome. Thank you very much. This includes great improvements

@chris-rock chris-rock merged commit bc7d176 into inspec:master Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants