ensure metadata release entry is a string #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/metadata-os-release
branch
2 times, most recently
from
bfe6231
to
48ae9f5
Compare
arlimus
reviewed
Nov 20, 2016
| @@ -68,7 +68,8 @@ def is_supported?(os, entry) | |||
| os.method(family_check).call | |||
| ) | |||
|
|
|||
| release_ok = release.nil? || os[:release] == release | |||
| # ensure we do have a string if we have a non-nil value eg. 16.06 | |||
| release_ok = release.nil? || os[:release] == release.to_s | |||
There was a problem hiding this comment.
Could we move this to finalize ?
There was a problem hiding this comment.
Sorry, finalize_supports my bad!
… float Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
arlimus
force-pushed
the
chris-rock/metadata-os-release
branch
from
48ae9f5
to
e3347f0
Compare
|
Thank you @chris-rock 👍 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by Shone Jacob in https://chefcommunity.slack.com/archives/inspec/p1479483621000703 InSpec is not handling the version numbers from Ubuntu properly.
inspec.yml:
Internally, YAML parses
16.04as a number instead as string. This PR fixes that behavior and ensurs that versions always compared as strings.