Adding windows_task resource #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: username-is-already-taken2 <digitalgaz@hotmail.com>
Signed-off-by: username-is-already-taken2 <digitalgaz@hotmail.com>
username-is-already-taken2
force-pushed
the
digitalgaz/windows_task
branch
from
32138f6
to
4084a77
Compare
Signed-off-by: username-is-already-taken2 <digitalgaz@hotmail.com>
username-is-already-taken2
changed the title
|
Awesome work @username-is-already-taken2 and @cdbeard2016 |
|
Integration tests work smoothly and the unit test are great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Both Chris ( @cdbeard2016 ) and myself would like to put forward this PR to add the
windows_taskresource to inspecWe got the idea to create it from the issue #1214
We tried to meet all the contribution requirements, let us know if we fell short anywhere
Best Regards
Gary