clean up rspec_json_formatter #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/clean-up-formatter
branch
3 times, most recently
from
b54d8ee
to
5409744
Compare
vjeffrey
changed the title
vjeffrey
force-pushed
the
vj/clean-up-formatter
branch
2 times, most recently
from
8b46f65
to
2a64442
Compare
added 2 commits
November 28, 2016 15:42
Signed-off-by: Victoria Jeffrey <vjeffrey@chef.io>
chris-rock
force-pushed
the
vj/clean-up-formatter
branch
from
2a64442
to
2e25027
Compare
chris-rock
approved these changes
Nov 28, 2016
|
|
||
| # Takes current_control (called from flush_current_control) and returns | ||
| # fails, skips, passes. | ||
| def current_control_infos(current_control) |
| res = @current_control[:results] | ||
| # Determine title for control given current_control. | ||
| # Called from current_control_summary. | ||
| def current_control_title(current_control) |
| @colors = COLORS | ||
| @indicators = INDICATORS | ||
|
|
||
| @format = '%color%indicator%id%summary' |
|
Thank you @vjeffrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hack-days work to clean up rspec_json_formatter a bit. removed some unnecessary instance variables that were floating around and commented methods