fix bug: RegExp in processes resource can't match long-run process #1332 #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wing924
force-pushed
the
fix_regexp_in_processes
branch
from
d0e66a1
to
331637b
Compare
…spec#1332 Signed-off-by: Wei, He <weihe924stephen@gmail.com>
Wing924
force-pushed
the
fix_regexp_in_processes
branch
from
331637b
to
861856f
Compare
|
@Wing924 awesome addition. Lets add a test to our unit tests to ensure future changes will not break this behavior: https://github.com/chef/inspec/blob/master/test/unit/resources/processes_test.rb |
Wing924
force-pushed
the
fix_regexp_in_processes
branch
2 times, most recently
from
98fc30d
to
546625d
Compare
Signed-off-by: Wei, He <weihe924stephen@gmail.com>
Wing924
force-pushed
the
fix_regexp_in_processes
branch
from
546625d
to
fd04daf
Compare
|
@chris-rock Thank you for your comment. I added the test cases. |
|
Great work @Wing924. Thank you for your contribution. I take care of the failing tests, since they are not related to your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1332 by change RegExp