Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cached profile for compliance dependencies if vendored #1348

Merged
merged 1 commit into from
Dec 8, 2016
Merged

use cached profile for compliance dependencies if vendored #1348

merged 1 commit into from
Dec 8, 2016

Conversation

chris-rock
Copy link
Contributor

This PR prevents the case, where vendored profiles still try to fetch profiles from Chef Compliance

inspec check my-cis-profile

Cannot fetch compliance://cis/cis-amazonlinux-2014.09-2015.03-level1 because your compliance token has not been
configured.

Please login using

    inspec compliance login https://your_compliance_server --user admin --insecure --token 'PASTE TOKEN HERE'

@chris-rock chris-rock added the Type: Bug Feature not working as expected label Dec 8, 2016
@chris-rock chris-rock force-pushed the chris-rock/use-cached-compliance branch from 4c31e2f to aa1dc85 Compare December 8, 2016 10:03
@chris-rock
Copy link
Contributor Author

Integration tests will follow, once the Automate tests are included

@chris-rock
use cached profile for compliance dependencies if vendored
7a0aa49 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock chris-rock force-pushed the chris-rock/use-cached-compliance branch from aa1dc85 to 7a0aa49 Compare December 8, 2016 10:12
alexpop
alexpop approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@alexpop alexpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris 💯

@chris-rock chris-rock merged commit db96fe0 into master Dec 8, 2016
@chris-rock chris-rock deleted the chris-rock/use-cached-compliance branch December 8, 2016 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpop alexpop alexpop approved these changes

Assignees
No one assigned
Labels
Type: Bug Feature not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-rock @alexpop