Add profile version to archive #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxxstorm
force-pushed
the
archive_versioning
branch
from
354c19b
to
2ad78cd
Compare
|
Great improvement @jaxxstorm Can you rebase and fix the lint error? Happy to merge it then. |
chris-rock
reviewed
Dec 14, 2016
| @@ -399,9 +399,12 @@ def archive_name(opts) | |||
| name = params[:name] || | |||
| fail('Cannot create an archive without a profile name! Please '\ | |||
| 'specify the name in metadata or use --output to create the archive.') | |||
| version = params[:version] || | |||
| fail('Cannot create an archive with a profile version! Please '\ | |||
| 'specify the version in metadat or use --output to create the archive.') | |||
jaxxstorm
force-pushed
the
archive_versioning
branch
from
2ad78cd
to
ad06068
Compare
|
@chris-rock I fixed the lint error, but we're still failing here. Any tips? |
|
@jaxxstorm We need to update our functional tests as well: You can quickly run the specific tests locally with: |
jaxxstorm
force-pushed
the
archive_versioning
branch
from
90dc1ae
to
ad06068
Compare
Signed-off-by: Lee Briggs <lbriggs@apptio.com>
jaxxstorm
force-pushed
the
archive_versioning
branch
from
512eb95
to
941c1ba
Compare
Signed-off-by: Lee Briggs <lbriggs@apptio.com>
jaxxstorm
force-pushed
the
archive_versioning
branch
from
941c1ba
to
0253031
Compare
|
Woot, finally got there, thanks @chris-rock ! |
|
@jaxxstorm Cool. Thank you for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1350
Probably needs some discussion here...