Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display if inspec version is outdated #1365

Merged
merged 1 commit into from
Jan 3, 2017
Merged

display if inspec version is outdated #1365

merged 1 commit into from
Jan 3, 2017

Conversation

chris-rock
Copy link
Contributor 

$ inspec version
1.7.0

Your version of InSpec is out of date! The latest version is 1.7.2.

@chris-rock chris-rock added in progress Type: Enhancement Improves an existing feature and removed in progress labels Dec 15, 2016
@chris-rock chris-rock force-pushed the chris-rock/outdated branch 2 times, most recently from 259df3d to 9f0423c Compare December 15, 2016 15:14
@arlimus
Copy link
Contributor

arlimus commented Dec 15, 2016

Nice feature overall! Reminds users if there is something new already or how far they are behind latest.

I think we should be careful here, since inspec version should be very highly failure resistant. More handling around timeouts to kill this would be great.

@chris-rock
Copy link
Contributor Author

@arlimus Great idea. I agree we should be really careful. I added a timeout of 500 milliseconds

@chris-rock
display if inspec version is outdated
f0cdad8 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@arlimus
Copy link
Contributor

arlimus commented Jan 3, 2017

Kudos!

@arlimus arlimus merged commit 823b140 into master Jan 3, 2017
@arlimus arlimus deleted the chris-rock/outdated branch January 3, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-rock @arlimus