control and lib_eval_context unit tests #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremymv2 Can you please rebase on latest master? Everything should be green by then. |
Signed-off-by: Jeremy J. Miller <jm@chef.io>
jeremymv2
force-pushed
the
jeremymv2/add_profile_unit_tests
branch
from
4146213
to
72b0c0d
Compare
|
@chris-rock sorry for the delay. I was fully checked out on PTO - back now! |
|
@jeremymv2 Cool. No worries. Thank you for adding the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that these unit tests were not being executed due to their file names ending in
.._tests.rbinstead of.._test.rb. Not sure if that is intentional or not. I did rename both and I had to modifycontrol_eval_context_test.rbbecause it seemed to be based on an outdated implementation?Signed-off-by: Jeremy J. Miller jm@chef.io