Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop ruby 1.9.3 #1384

Merged
merged 2 commits into from
Jan 3, 2017
Merged

drop ruby 1.9.3 #1384

merged 2 commits into from
Jan 3, 2017

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented Jan 2, 2017 •
edited by arlimus
Loading

This PR:

  • removes ruby 1.9.3 (its is becoming too difficult to maintain 1.9.3 with pinning all dependencies in Gemfile)
  • update functional tests to meet the updated profile

@chris-rock chris-rock force-pushed the chris-rock/drop-193 branch 2 times, most recently from 54596aa to 46c604b Compare January 2, 2017 11:20
@chris-rock chris-rock changed the title drop ruby 1.9.3 and add 2.4.0 drop ruby 1.9.3 Jan 2, 2017
@chris-rock chris-rock mentioned this pull request Jan 2, 2017
Merged
arlimus
arlimus suggested changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Ruby 1.9.3 officially ended Feb 23rd 2015, however, we had continue to support it because it is still in supported distros like RHEL6.

We will continue to support a broad range of runtimes, but need to reduce 1.9 at this point, because it is blocking the selection of newer gem releases in our dependencies.

.travis.yml
- rvm: 2.2.5
- rvm: 2.1.10
- rvm: 2.2.6
- rvm: 2.3.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding 2.3.3 here, what do think about changing all the 2.3.1 runs below to this release instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan?

appveyor.yml
@@ -6,7 +6,6 @@ environment:
bundler_url: https://rubygems.org/downloads/bundler-1.9.9.gem

matrix:
- ruby_version: "193"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho we should either add ruby_version 21 here or remove it from bundler above; what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you are requesting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add ruby 2.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chris-rock
drop ruby 1.9.3
efc8542 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
update functional tests
ab097ef 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@arlimus arlimus merged commit 7d88476 into master Jan 3, 2017
@arlimus
Copy link
Contributor

arlimus commented Jan 3, 2017

Thank you!

@arlimus arlimus deleted the chris-rock/drop-193 branch January 3, 2017 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlimus arlimus arlimus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-rock @arlimus