Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve http header handling #1432

Merged
merged 1 commit into from
Jan 26, 2017
Merged

improve http header handling #1432

merged 1 commit into from
Jan 26, 2017

Conversation

chris-rock
Copy link
Contributor

  • removes method_missing
  • exposes headers as a hash
  • improves output of to_s method

@chris-rock
Copy link
Contributor Author

cc @guilhem

@chris-rock chris-rock self-assigned this Jan 26, 2017
@chris-rock chris-rock force-pushed the chris-rock/improve-http branch 2 times, most recently from 1069170 to fd8748b Compare January 26, 2017 13:43
@guilhem
Copy link
Contributor

guilhem commented Jan 26, 2017 •
edited
Loading

LGTM

I wasn't a huge fan of method_missing.
But it lack doc change on headers ;)

@chris-rock
Copy link
Contributor Author

@guilhem :-) Good catch

@chris-rock
improve http header handling
976e5d8 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock chris-rock merged commit 41df33b into master Jan 26, 2017
@chris-rock chris-rock deleted the chris-rock/improve-http branch January 26, 2017 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chris-rock chris-rock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-rock @guilhem