Fix xinetd parsing of services from the same file. Expose resource.protocols #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otocols Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/fix-xinetd-parsing
branch
from
1d33812
to
a3de32a
Compare
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/fix-xinetd-parsing
branch
from
104dbd9
to
6f3a9d2
Compare
alexpop
changed the title
chris-rock
approved these changes
Jan 31, 2017
|
Thank you @alexpop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When services are in the same file, with the
tcpandudpprotocol configurations, only the second one was being exposed by the resource. This PR fixes that.It also adds another mocked xinetd file, same way they are by default in Ubuntu:
[root@vagrant-local-ubuntu1404]# ls /etc/xinetd.d/echo* /etc/xinetd.d/echowhere the existing
chargenmocked configs follow the split RedHat format: