Add FilterTable support to processes resource #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
force-pushed
the
ap/processes-filter
branch
from
dd2c59f
to
13c73e7
Compare
|
Hey @alexpop , awesome to see this move to FilterTable!! Could you please also change the current tests from |
alexpop
force-pushed
the
ap/processes-filter
branch
from
24de310
to
4d74d1c
Compare
alexpop
changed the title
alexpop
force-pushed
the
ap/processes-filter
branch
from
871335d
to
c860fd2
Compare
Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
…port Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/processes-filter
branch
from
c860fd2
to
83e44f9
Compare
|
Awesome work, thank you @alexpop ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for a quick review before writing tests for the new properties.
Ok with the
.listdeprecation for the commonly usedentries?