Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new crontab resource #1482

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Adding new crontab resource #1482

merged 1 commit into from
Feb 10, 2017

Conversation

adamleff
Copy link
Contributor

@adamleff adamleff commented Feb 9, 2017

The crontab resource parses a particular user's crontab file into
individual entries and allows the user to assert information about
each entry as needed.

Signed-off-by: Adam Leff adam@leff.co

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge contribution, kudos @adamleff !! Includes tests, docs, everything I can ask for.

Just one tiny comment vv (also same situation in docs)

its('commands') { should include '/path/to/some/script' }
end

describe crontab('myuser').command('/home/myuser/build.sh') do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that the resource supports the singular right now. It works with commands but not command out of the box. That's a whole other discussion, but lovely to solve :)

@adamleff adamleff force-pushed the adamleff/add-crontab-resource branch from 791b061 to afd72c5 Compare February 10, 2017 14:14
The crontab resource parses a particular user's crontab file into
individual entries and allows the user to assert information about
each entry as needed.

Signed-off-by: Adam Leff <adam@leff.co>
@adamleff adamleff force-pushed the adamleff/add-crontab-resource branch from afd72c5 to 417b791 Compare February 10, 2017 14:33
@adamleff
Copy link
Contributor Author

@arlimus this should be good for another review! Fixed the example/docs, and also added a skip_resource for non-unix OSs.

@arlimus
Copy link
Contributor

arlimus commented Feb 10, 2017

Awesome @adamleff thank you 😄
You are setting a high bar here

@arlimus arlimus merged commit 09cc7c3 into master Feb 10, 2017
@arlimus arlimus deleted the adamleff/add-crontab-resource branch February 10, 2017 19:53
alexpop pushed a commit that referenced this pull request Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants