-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new crontab resource #1482
Conversation
c5c8890
to
791b061
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge contribution, kudos @adamleff !! Includes tests, docs, everything I can ask for.
Just one tiny comment vv (also same situation in docs)
lib/resources/crontab.rb
Outdated
its('commands') { should include '/path/to/some/script' } | ||
end | ||
|
||
describe crontab('myuser').command('/home/myuser/build.sh') do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that the resource supports the singular right now. It works with commands
but not command
out of the box. That's a whole other discussion, but lovely to solve :)
791b061
to
afd72c5
Compare
The crontab resource parses a particular user's crontab file into individual entries and allows the user to assert information about each entry as needed. Signed-off-by: Adam Leff <adam@leff.co>
afd72c5
to
417b791
Compare
@arlimus this should be good for another review! Fixed the example/docs, and also added a |
Awesome @adamleff thank you 😄 |
The crontab resource parses a particular user's crontab file into
individual entries and allows the user to assert information about
each entry as needed.
Signed-off-by: Adam Leff adam@leff.co